Tools: use cmdliner library to parse arguments#910
Open
aspeddro wants to merge 14 commits intorescript-lang:masterfrom
Open
Tools: use cmdliner library to parse arguments#910aspeddro wants to merge 14 commits intorescript-lang:masterfrom
cmdliner library to parse arguments#910aspeddro wants to merge 14 commits intorescript-lang:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some advantages:
cmdlinerdoesn't have dependenciesThere is breaking change bc argument names now start with two dashes
--Other changes
Commands removed:
-all-cmt-dce-cmt-exception-cmt-termination-cmtThe four commands above allow you to set the path to the cmt files. Then you could call it as follows without any error:
But the path of
-dce-cmtoverwrites that of-all-cmt. It also doesn't make sense to use-all-cmtand-dce-cmtsince-all-cmtreports all types of analysisNow: A flag for the analysis type,
--dce,--exceptionor--termination. Running command without argumentrescript-tools reanalyzewill report all kind of analysis.The argument to cmt path is
--cmt-pathSome Examples
Report all kinds of analysis (no need arg
all)Report only dce
Report only termination
Report exception and termination from custom cmt path